]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cpufreq: nforce2: fix reference count leak in nforce2
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 27 Oct 2025 15:04:45 +0000 (23:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Jan 2026 11:57:15 +0000 (12:57 +0100)
commit8f92817b6f100397d24a59a153f96a67fee2a7bc
tree4a8ceb966093d9f7e04da85d0fca2586d6ba2125
parent87f11fea5acb300dfe491715868367a1d4bdd9a4
cpufreq: nforce2: fix reference count leak in nforce2

commit 9600156bb99852c216a2128cdf9f114eb67c350f upstream.

There are two reference count leaks in this driver:

1. In nforce2_fsb_read(): pci_get_subsys() increases the reference count
   of the PCI device, but pci_dev_put() is never called to release it,
   thus leaking the reference.

2. In nforce2_detect_chipset(): pci_get_subsys() gets a reference to the
   nforce2_dev which is stored in a global variable, but the reference
   is never released when the module is unloaded.

Fix both by:
- Adding pci_dev_put(nforce2_sub5) in nforce2_fsb_read() after reading
  the configuration.
- Adding pci_dev_put(nforce2_dev) in nforce2_exit() to release the
  global device reference.

Found via static analysis.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cpufreq/cpufreq-nforce2.c