]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "nfs: don't reuse partially completed requests in nfs_lock_and_join_requests"
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 5 Nov 2024 02:09:21 +0000 (21:09 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 13:03:05 +0000 (14:03 +0100)
commit8f95ffb8f86e79e3d44566b8c5a1a925ea639f8c
treec040513aa61e418bbc676a1357bcce859d019848
parentc5b75986dbae69f58cab94f05d2d28a24f3b2c34
Revert "nfs: don't reuse partially completed requests in nfs_lock_and_join_requests"

[ Upstream commit 66f9dac9077c9c063552e465212abeb8f97d28a7 ]

This reverts commit b571cfcb9dcac187c6d967987792d37cb0688610.

This patch appears to assume that if one request is complete, then the
others will complete too before unlocking. That is not a valid
assumption, since other requests could hit a non-fatal error or a short
write that would cause them not to complete.

Reported-by: Igor Raits <igor@gooddata.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219508
Fixes: b571cfcb9dca ("nfs: don't reuse partially completed requests in nfs_lock_and_join_requests")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/write.c