]> git.ipfire.org Git - thirdparty/linux.git/commit
nfsd: use ATTR_DELEG in nfsd4_finalize_deleg_timestamps()
authorJeff Layton <jlayton@kernel.org>
Wed, 3 Dec 2025 15:52:15 +0000 (10:52 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 25 Dec 2025 02:32:34 +0000 (21:32 -0500)
commit8f9e967830ff32ab7756f530a36adf74a9f12b76
tree975793bd25132ecacc590c53990247c592324ea7
parent8072e34e1387d03102b788677d491e2bcceef6f5
nfsd: use ATTR_DELEG in nfsd4_finalize_deleg_timestamps()

When finalizing timestamps that have never been updated and preparing to
release the delegation lease, the notify_change() call can trigger a
delegation break, and fail to update the timestamps. When this happens,
there will be messages like this in dmesg:

    [ 2709.375785] Unable to update timestamps on inode 00:39:263: -11

Since this code is going to release the lease just after updating the
timestamps, breaking the delegation is undesirable. Fix this by setting
ATTR_DELEG in ia_valid, in order to avoid the delegation break.

Fixes: e5e9b24ab8fa ("nfsd: freeze c/mtime updates with outstanding WRITE_ATTRS delegation")
Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c