]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wifi: ath12k: remove redundant pci_set_drvdata() call
authorAlexander Minchev <adminchev@proton.me>
Thu, 27 Nov 2025 07:29:37 +0000 (07:29 +0000)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Fri, 16 Jan 2026 01:19:36 +0000 (17:19 -0800)
commit8fb264d1a0c5b3feae5f492ee2bc2997b71b63e3
tree6c0be98d754d4953df0a03669d8896cb173bcaee
parent9269caf5a7ff2c0b1f37e06f10eee68d5bf1049e
wifi: ath12k: remove redundant pci_set_drvdata() call

pci_set_drvdata() is called twice in ath12k_pci_probe() with the
same pointer. Remove the earlier call so drvdata is set after
ath12k_base and ath12k_pci initialization is complete.

Having two calls might suggest that drvdata needs to be set early for
some reason, even though it is not used until after the 'ab' struct
ath12k_base is fully populated. Even though exact placement is
not critical, keeping a single pci_set_drvdata() at the end of
the initialization makes it clearer that drvdata points to a
fully initialized structure and avoids confusion for future changes.

Tested on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3

Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Signed-off-by: Alexander Minchev <adminchev@proton.me>
Link: https://patch.msgid.link/20251127072839.14167-2-adminchev@proton.me
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/pci.c