]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regulator: fixed: Rely on the core freeing the enable GPIO
authorMark Brown <broonie@kernel.org>
Thu, 4 Dec 2025 19:39:34 +0000 (19:39 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:03:36 +0000 (14:03 +0100)
commit8fee481ee6c0d1e3ca64d0cabaa2653533d34a23
tree6ed36203f9abc66609403598cd2abc98c611ea43
parentbc6761c022558aa3f3eea012a28dd9624abfffac
regulator: fixed: Rely on the core freeing the enable GPIO

[ Upstream commit 79a45ddcdbba330f5139c7c7ff7042d69cf147b2 ]

In order to simplify ownership rules for enable GPIOs supplied by drivers
regulator_register() always takes ownership of them, even if it ends up
failing for some other reason. We therefore should not free the GPIO if
registration fails but just let the core worry about things.

Fixes: 636f4618b1cd (regulator: fixed: fix GPIO descriptor leak on register failure)
Reported-by: Diederik de Haas <diederik@cknow-tech.com>
Closes: https://lore.kernel.org/r/DEPEYUF5BRGY.UKFBWRRE8HNP@cknow-tech.com
Tested-by: Diederik de Haas <diederik@cknow-tech.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20251204-regulator-fixed-fix-gpiod-leak-v1-1-48efea5b82c2@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/fixed.c