]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PCI/ERR: Notify drivers on failure to recover
authorLukas Wunner <lukas@wunner.de>
Wed, 13 Aug 2025 05:11:03 +0000 (07:11 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 13 Aug 2025 18:20:46 +0000 (13:20 -0500)
commit9011f0667c93df2034f2ff33eae37ddf9bdd0ef9
treec446fc6f34b76a09d2f627b0754015796480d072
parent1cbc5e25fb70e942a7a735a1f3d6dd391afc9b29
PCI/ERR: Notify drivers on failure to recover

According to Documentation/PCI/pci-error-recovery.rst, the following shall
occur on failure to recover from a PCIe Uncorrectable Error:

  STEP 6: Permanent Failure
  -------------------------
  A "permanent failure" has occurred, and the platform cannot recover
  the device.  The platform will call error_detected() with a
  pci_channel_state_t value of pci_channel_io_perm_failure.

  The device driver should, at this point, assume the worst. It should
  cancel all pending I/O, refuse all new I/O, returning -EIO to
  higher layers. The device driver should then clean up all of its
  memory and remove itself from kernel operations, much as it would
  during system shutdown.

Sathya notes that AER does not call error_detected() on failure and thus
deviates from the document (as well as EEH, for which the document was
originally added).

Most drivers do nothing on permanent failure, but the SCSI drivers and a
number of Ethernet drivers do take advantage of the notification to flush
queues and give up resources.

Amend AER to notify such drivers and align with the documentation and EEH.

Link: https://lore.kernel.org/r/f496fc0f-64d7-46a4-8562-dba74e31a956@linux.intel.com/
Suggested-by: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/ec212d4d4f5c65d29349df33acdc9768ff8279d1.1755008151.git.lukas@wunner.de
drivers/pci/pcie/err.c