]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Don't use virtual destructor in addrmap
authorTom Tromey <tromey@adacore.com>
Mon, 26 Feb 2024 18:39:49 +0000 (11:39 -0700)
committerTom Tromey <tromey@adacore.com>
Thu, 21 Mar 2024 18:21:23 +0000 (12:21 -0600)
commit9069d69398649cd9a54e4dcac8548b10ece8a304
tree3c9a979bfb2c77fce0113d01ff38d9787d9721e4
parent3984e52f7f4bca4641b2c59ba2730f71263ad97d
Don't use virtual destructor in addrmap

The addrmap polymorphism is sort of "phony" in that there isn't really
code in the tree that can be presented with either type.  I haven't
tried to fix this (though perhaps I may); but meanwhile it's handy for
the next patch if addrmap_fixed has a trivial destructor.  This patch
achieves this by making the addrmap destructor non-virtual, and also
making it protected so that objects of any of these types cannot be
destroyed when only the base class is known.
gdb/addrmap.h