]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: input: do not report stylus battery state as "full"
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 29 Jun 2021 18:25:50 +0000 (11:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:48:01 +0000 (11:48 +0200)
commit9076623badf1dba7a45743bad393ede47ca3f72e
tree55521562f369c0e32d935a0ce910bfff854b5fb3
parentb04b4e98bb7563fb64e5b5161f935a5a3b0c79be
HID: input: do not report stylus battery state as "full"

[ Upstream commit f4abaa9eebde334045ed6ac4e564d050f1df3013 ]

The power supply states of discharging, charging, full, etc, represent
state of charging, not the capacity level of the battery (for which
we have a separate property). Current HID usage tables to not allow
for expressing charging state of the batteries found in generic
styli, so we should simply assume that the battery is discharging
even if current capacity is at 100% when battery strength reporting
is done via HID interface. In fact, we were doing just that before
commit 581c4484769e.

This change helps UIs to not mis-represent fully charged batteries in
styli as being charging/topping-off.

Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
Reported-by: Kenneth Albanowski <kenalba@google.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-input.c