]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
raid1: fix nr_pending leak in REQ_ATOMIC bad-block error path
authorAbd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Sat, 30 May 2026 15:14:11 +0000 (15:14 +0000)
committerYu Kuai <yukuai@fygo.io>
Sun, 31 May 2026 11:09:19 +0000 (19:09 +0800)
commit909d9dc3b5730c8ed7b764c68bc788342df2a07b
treeb15c74a2aa2deb400c25c98547f6cf6470a522de
parent6e3b0b91334d1dfaa20ca55eac835f5945a3b7c8
raid1: fix nr_pending leak in REQ_ATOMIC bad-block error path

In raid1_write_request(), each per-mirror loop iteration begins by
incrementing rdev->nr_pending. If a REQ_ATOMIC write encounters a
badblock within the requested range, the code jumps to err_handle
without dropping the reference taken for the current mirror.

err_handle's cleanup loop will only decrements for k < i and
r1_bio->bios[k] is non-NULL. The current slot is therefore skipped,
leaving its nr_pending reference leaked permanently. The reference
prevents the rdev from ever being removed, since raid1_remove_conf()
refuses to remove an rdev with nr_pending > 0.

Fix this by calling rdev_dec_pending() before jumping to err_handle.

Fixes: f2a38abf5f1c ("md/raid1: Atomic write support")
Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Link: https://patch.msgid.link/20260530151411.4119-1-abd.masalkhi@gmail.com
Signed-off-by: Yu Kuai <yukuai@fygo.io>
drivers/md/raid1.c