]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: mpc52xx: Add cancel_work_sync before module remove
authorPei Xiao <xiaopei01@kylinos.cn>
Thu, 28 Nov 2024 08:38:17 +0000 (16:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:15 +0000 (20:03 +0100)
commit90b72189de2cddacb26250579da0510b29a8b82b
tree272efc9d81e31892be68cb856c916efe214a2bc4
parentcd3018c9b2ad6ff64cc5f0096f3c108e1d807cbe
spi: mpc52xx: Add cancel_work_sync before module remove

[ Upstream commit 984836621aad98802d92c4a3047114cf518074c8 ]

If we remove the module which will call mpc52xx_spi_remove
it will free 'ms' through spi_unregister_controller.
while the work ms->work will be used. The sequence of operations
that may lead to a UAF bug.

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in mpc52xx_spi_remove.

Fixes: ca632f556697 ("spi: reorganize drivers")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://patch.msgid.link/1f16f8ae0e50ca9adb1dc849bf2ac65a40c9ceb9.1732783000.git.xiaopei01@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mpc52xx.c