]> git.ipfire.org Git - thirdparty/linux.git/commit
PCI: endpoint: Fix configfs group removal on driver teardown
authorDamien Le Moal <dlemoal@kernel.org>
Tue, 24 Jun 2025 11:45:44 +0000 (20:45 +0900)
committerManivannan Sadhasivam <mani@kernel.org>
Wed, 25 Jun 2025 22:09:12 +0000 (16:09 -0600)
commit910bdb8197f9322790c738bb32feaa11dba26909
treef11f1dee60a06861f031e61e6ccfd3e30dc7bce3
parentd79123d79a8154b4318529b7b2ff7e15806f480b
PCI: endpoint: Fix configfs group removal on driver teardown

An endpoint driver configfs attributes group is added to the
epf_group list of struct pci_epf_driver by pci_epf_add_cfs() but an
added group is not removed from this list when the attribute group is
unregistered with pci_ep_cfs_remove_epf_group().

Add the missing list_del() call in pci_ep_cfs_remove_epf_group()
to correctly remove the attribute group from the driver list.

With this change, once the loop over all attribute groups in
pci_epf_remove_cfs() completes, the driver epf_group list should be
empty. Add a WARN_ON() to make sure of that.

Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250624114544.342159-3-dlemoal@kernel.org
drivers/pci/endpoint/pci-ep-cfs.c
drivers/pci/endpoint/pci-epf-core.c