]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4: ip_check_defrag should correctly check return value of skb_copy_bits
authorAlexander Drozdov <al.drozdov@gmail.com>
Tue, 17 Feb 2015 10:33:46 +0000 (13:33 +0300)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 14 Mar 2015 19:37:11 +0000 (15:37 -0400)
commit913c52e4ef72da0a91ee55acdbce34072ac4011e
tree45c9511074257f3a13edefc663fe0b656d66f865
parentaaf410beca530f2c17de11ad7202a864876688c1
ipv4: ip_check_defrag should correctly check return value of skb_copy_bits

[ Upstream commit fba04a9e0c869498889b6445fd06cbe7da9bb834 ]

skb_copy_bits() returns zero on success and negative value on error,
so it is needed to invert the condition in ip_check_defrag().

Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before unsharing")
Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/ipv4/ip_fragment.c