]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/gud: fix accidentally deleted IS_ERR() check
authorRuben Wauters <rubenru09@aol.com>
Mon, 22 Sep 2025 17:32:20 +0000 (18:32 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 23 Sep 2025 08:02:44 +0000 (10:02 +0200)
commit915c306164f7e6187973855f75b4b1af7bc1d6ff
treeca486a375b8351e3cc5c80e190cb762421f10c2d
parent3a9cf301794c1a49d95eeb13119ff490fb5cfe88
drm/gud: fix accidentally deleted IS_ERR() check

During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in
commit 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with
drm versions"), the IS_ERR check was accidentally removed, breaking
the gud_connector_add_properties() function, as any valid pointer
in state_val would produce an error.

The warning was reported by kernel test robot, and is fixed in this patch.

Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/
Signed-off-by: Ruben Wauters <rubenru09@aol.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250922173836.5608-1-rubenru09@aol.com
drivers/gpu/drm/gud/gud_connector.c