]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ceph: use the mount idmap for the owner checks in the SET_LAYOUT ioctls
authorZhan Xusheng <zhanxusheng@xiaomi.com>
Mon, 27 Jul 2026 01:47:44 +0000 (09:47 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 12 Aug 2026 19:21:41 +0000 (21:21 +0200)
commit91880e4a7fac45bc407771bc57bbaf4f37e9b4c3
treec32bc60a5f3a06e305795d0a745bce7eb143b760
parent2c11c4bfdb7bd2808b3b3ac228e1f2d9bcf25457
ceph: use the mount idmap for the owner checks in the SET_LAYOUT ioctls

ceph_ioctl_set_layout() and ceph_ioctl_set_layout_policy() call
inode_owner_or_capable() with &nop_mnt_idmap instead of the idmap of the
mount the ioctl was issued on.

CephFS supports idmapped mounts (FS_ALLOW_IDMAP), so on such a mount this
compares the caller's fsuid against the unmapped on-disk owner rather than
the mapped owner: the actual owner can be wrongly denied with -EACCES and
an unrelated caller wrongly allowed.  Both functions already have the
struct file, so use file_mnt_idmap(file) instead.

Cc: stable@vger.kernel.org
Fixes: cee38bbf5556 ("ceph: add owner/capability checks for CEPH_IOC_SET_LAYOUT*")
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Reviewed-by: Xiubo Li <xiubo.li@clyso.com>
Reviewed-by: Alex Markuze <amarkuze@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/ioctl.c