]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mptcp: don't always assume copied data in mptcp_cleanup_rbuf()
authorPaolo Abeni <pabeni@redhat.com>
Mon, 30 Dec 2024 18:12:31 +0000 (19:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:30:07 +0000 (13:30 +0100)
commit91b493f15d65266ebba806553c97a2ae5df581ce
tree9e60e2c496d0d65fe1879feadca980475fba2e97
parentcbdb6a4c6a66b28abb329ec81b14c877af4fce7e
mptcp: don't always assume copied data in mptcp_cleanup_rbuf()

commit 551844f26da2a9f76c0a698baaffa631d1178645 upstream.

Under some corner cases the MPTCP protocol can end-up invoking
mptcp_cleanup_rbuf() when no data has been copied, but such helper
assumes the opposite condition.

Explicitly drop such assumption and performs the costly call only
when strictly needed - before releasing the msk socket lock.

Fixes: fd8976790a6c ("mptcp: be careful on MPTCP-level ack.")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20241230-net-mptcp-rbuf-fixes-v1-2-8608af434ceb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mptcp/protocol.c