]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
selftest/qemurunner: Work around possible control character contamination
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 13 Sep 2022 09:29:01 +0000 (10:29 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 13 Sep 2022 22:03:34 +0000 (23:03 +0100)
commit91b9e30e08695e715ef14c3df7471e8c99f9deb5
tree20d17ee53dfceb01f767a8954e06caf68c06a78d
parentd042923262130b6b96f703b5cd4184f659caeb92
selftest/qemurunner: Work around possible control character contamination

Using a binary string as the login banner search expression is fraught with
risks. We've seen cases on the autobuilder where "login:" is clearly shown
but the code hasn't triggered. The most likely cause is hidden control characters
in the output causing the search to fail.

Take the opportunity to remove the horrible binary string search, at the expense of
decoding the bootlog multiple times.

Tweak the logging so we can know which log was printed (self.msg or bootlog)
just in case this isn't the issue and we need more information in future.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes-recipe/testimage.bbclass
meta/lib/oeqa/utils/qemurunner.py