]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
random: Add comment to random_initialize()
authorTony Luck <tony.luck@intel.com>
Mon, 23 Jul 2012 16:47:57 +0000 (09:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Aug 2012 14:52:49 +0000 (07:52 -0700)
commit91e66eea0fe522c44a8ac10e09e05c4422f56512
tree8b2de75b761e34189b24816102f6014d5a73dee8
parent458f9b009bce81a9f5644a08018579abc60d865b
random: Add comment to random_initialize()

commit cbc96b7594b5691d61eba2db8b2ea723645be9ca upstream.

Many platforms have per-machine instance data (serial numbers,
asset tags, etc.) squirreled away in areas that are accessed
during early system bringup. Mixing this data into the random
pools has a very high value in providing better random data,
so we should allow (and even encourage) architecture code to
call add_device_randomness() from the setup_arch() paths.

However, this limits our options for internal structure of
the random driver since random_initialize() is not called
until long after setup_arch().

Add a big fat comment to rand_initialize() spelling out
this requirement.

Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/random.c