]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ata: libata-eh: Do not use ATAPI DMA for a device limited to PIO mode
authorNiklas Cassel <cassel@kernel.org>
Fri, 21 Feb 2025 01:54:23 +0000 (02:54 +0100)
committerNiklas Cassel <cassel@kernel.org>
Fri, 21 Feb 2025 17:28:22 +0000 (18:28 +0100)
commit91ec84f8eaddbc93d7c62e363d68aeb7b89879c7
tree8493dc3b49aaef616c18b1ccb6e443e5e370aa71
parent08a04e20593b8efbc6dae99be6e965104826bfe1
ata: libata-eh: Do not use ATAPI DMA for a device limited to PIO mode

atapi_eh_request_sense() currently uses ATAPI DMA if the SATA controller
has ATA_FLAG_PIO_DMA (PIO cmds via DMA) set.

However, ATA_FLAG_PIO_DMA is a flag that can be set by a low-level driver
on a port at initialization time, before any devices are scanned.

If a controller detects a connected device that only supports PIO, we set
the flag ATA_DFLAG_PIO.

Modify atapi_eh_request_sense() to not use ATAPI DMA if the connected
device only supports PIO.

Reported-by: Philip Pemberton <lists@philpem.me.uk>
Closes: https://lore.kernel.org/linux-ide/c6722ee8-5e21-4169-af59-cbbae9edc02f@philpem.me.uk/
Tested-by: Philip Pemberton <lists@philpem.me.uk>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250221015422.20687-2-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-eh.c