]> git.ipfire.org Git - thirdparty/grub.git/commit
kern/fs: The grub_fs_probe() should dprint errors from filesystems
authorRobbie Harwood <rharwood@redhat.com>
Fri, 15 Jul 2022 20:13:01 +0000 (16:13 -0400)
committerDaniel Kiper <daniel.kiper@oracle.com>
Wed, 27 Jul 2022 17:20:53 +0000 (19:20 +0200)
commit92005be6d82b275e32bd74d1aabc45461e70db0d
treee821507477972b4cc95ac8fd22870cb3436a81c0
parent9b6f16501a64727a62864882aeedf7ecd3667631
kern/fs: The grub_fs_probe() should dprint errors from filesystems

When filesystem detection fails, all that's currently debug-logged is
a series of messages like:

    grub-core/kern/fs.c:56:fs: Detecting ntfs...
    grub-core/kern/fs.c:76:fs: ntfs detection failed.

repeated for each filesystem. Any messages provided to grub_error() by
the filesystem are lost, and one has to break out gdb to figure out what
went wrong.

With this change, one instead sees:

    grub-core/kern/fs.c:56:fs: Detecting fat...
    grub-core/osdep/hostdisk.c:357:hostdisk: reusing open device
    `/path/to/device'
    grub-core/kern/fs.c:77:fs: error: invalid modification timestamp for /.
    grub-core/kern/fs.c:79:fs: fat detection failed.

in the debug prints.

Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/kern/fs.c