]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/panthor: Fix NULL pointer dereference on panthor_fw_unplug
authorKarunika Choo <karunika.choo@arm.com>
Mon, 15 Dec 2025 20:33:12 +0000 (20:33 +0000)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 17 Dec 2025 13:15:24 +0000 (14:15 +0100)
commit920c6af98e98e6afedf6318a75bac95af8415c6c
treeb828734096ce9f8f73d8f87408e5f3a28fc464aa
parentaf586cc6df0bd56d4a3d05d5e6db0b193233fc51
drm/panthor: Fix NULL pointer dereference on panthor_fw_unplug

This patch removes the MCU halt and wait for halt procedures during
panthor_fw_unplug() as the MCU can be in a variety of states or the FW
may not even be loaded/initialized at all, the latter of which can lead
to a NULL pointer dereference.

It should be safe on unplug to just disable the MCU without waiting for
it to halt as it may not be able to.

Fixes: 514072549865 ("drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs")
Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Karunika Choo <karunika.choo@arm.com>
Reviewed-by: Liviu Dudau <liviu@dudau.co.uk>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patch.msgid.link/20251215203312.1084182-1-karunika.choo@arm.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_fw.c