]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
videobuf2-v4l2: Verify planes array in buffer dequeueing
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sun, 3 Apr 2016 19:31:03 +0000 (16:31 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 May 2016 21:49:08 +0000 (14:49 -0700)
commit922ff7af18370b752204c03e75e3dc3a2c50127d
tree9fb1a7770e367ccc0c7207f2a3f95216a256d552
parentef468ad540f990e0f479a7548aea7dd089fdbd5a
videobuf2-v4l2: Verify planes array in buffer dequeueing

commit 2c1f6951a8a82e6de0d82b1158b5e493fc6c54ab upstream.

When a buffer is being dequeued using VIDIOC_DQBUF IOCTL, the exact buffer
which will be dequeued is not known until the buffer has been removed from
the queue. The number of planes is specific to a buffer, not to the queue.

This does lead to the situation where multi-plane buffers may be requested
and queued with n planes, but VIDIOC_DQBUF IOCTL may be passed an argument
struct with fewer planes.

__fill_v4l2_buffer() however uses the number of planes from the dequeued
videobuf2 buffer, overwriting kernel memory (the m.planes array allocated
in video_usercopy() in v4l2-ioctl.c)  if the user provided fewer
planes than the dequeued buffer had. Oops!

Fixes: b0e0e1f83de3 ("[media] media: videobuf2: Prepare to divide videobuf2")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/v4l2-core/videobuf2-v4l2.c