]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't elide casting to typmod -1.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 20 Sep 2021 15:48:52 +0000 (11:48 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 20 Sep 2021 15:48:52 +0000 (11:48 -0400)
commit923b7efc259818688979f38ba88cba0d0d41ba10
tree10a1c13045f13af07fb8891559ede20dfbeaf5b2
parent61fb2b98f9df8bd770747b641d26615dc2d15cf8
Don't elide casting to typmod -1.

Casting a value that's already of a type with a specific typmod
to an unspecified typmod doesn't do anything so far as run-time
behavior is concerned.  However, it really ought to change the
exposed type of the expression to match.  Up to now,
coerce_type_typmod hasn't bothered with that, which creates gotchas
in contexts such as recursive unions.  If for example one side of
the union is numeric(18,3), but it needs to be plain numeric to
match the other side, there's no direct way to express that.

This is easy enough to fix, by inserting a RelabelType to update the
exposed type of the expression.  However, it's a bit nervous-making
to change this behavior, because it's stood for a really long time.
But no complaints have emerged about 14beta3, so go ahead and
back-patch.

Back-patch of 5c056b0c2 into previous supported branches.

Discussion: https://postgr.es/m/CABNQVagu3bZGqiTjb31a8D5Od3fUMs7Oh3gmZMQZVHZ=uWWWfQ@mail.gmail.com
Discussion: https://postgr.es/m/1488389.1631984807@sss.pgh.pa.us
src/backend/parser/parse_coerce.c
src/test/regress/expected/expressions.out
src/test/regress/sql/expressions.sql