]> git.ipfire.org Git - thirdparty/samba.git/commit
CVE-2018-10919 tests: Add test case for object visibility with limited rights
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 31 Jul 2018 02:14:20 +0000 (14:14 +1200)
committerKarolin Seeger <kseeger@samba.org>
Mon, 13 Aug 2018 07:13:36 +0000 (09:13 +0200)
commit924f87cb74a383f2dc1acfc33c1021d8399b5e40
treec29e2ba5dc699152f266b550510da5d8b97dafa2
parent33887063b0623a37e954ce318cbc5cd21e079a72
CVE-2018-10919 tests: Add test case for object visibility with limited rights

Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.

All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).

This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.

This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
selftest/knownfail.d/acl [new file with mode: 0644]
source4/dsdb/tests/python/acl.py