]> git.ipfire.org Git - thirdparty/haproxy.git/commit
CLEANUP: conn: Do not pass a pointer to likely
authorTim Duesterhus <tim@bastelstu.be>
Fri, 21 Feb 2020 12:02:03 +0000 (13:02 +0100)
committerWilly Tarreau <w@1wt.eu>
Tue, 25 Feb 2020 06:30:49 +0000 (07:30 +0100)
commit927063b8920c275ad6599b4cafc7b8742f5cc626
tree19efaaa283c8da83e0574c092a5cf881c983cf8e
parent89ee79845cf2a82c47a6560644773ef8b70eef77
CLEANUP: conn: Do not pass a pointer to likely

Move the `!` inside the likely and negate it to unlikely.

The previous version should not have caused issues, because it is converted
to a boolean / integral value before being passed to __builtin_expect(), but
it's certainly unusual.

[wt: this was not a bug but purposely written like this to improve code
 generation on older compilers but not needed anymore as described here:
 https://www.mail-archive.com/haproxy@formilux.org/msg36392.html ]
include/proto/connection.h