]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
klist: del waiter from klist_remove_waiters before wakeup waitting process
authorwang, biao <biao.wang@intel.com>
Thu, 16 May 2013 01:50:13 +0000 (09:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Jun 2013 19:46:36 +0000 (12:46 -0700)
commit929b30b9d3f530900c6e3176b1cf29fbcf307e25
tree71f022ee09002b282599f9db07abf6cb2011bfb6
parentc0872911a5926b9c0a3e570cf8bf2a027275a664
klist: del waiter from klist_remove_waiters before wakeup waitting process

commit ac5a2962b02f57dea76d314ef2521a2170b28ab6 upstream.

There is a race between klist_remove and klist_release. klist_remove
uses a local var waiter saved on stack. When klist_release calls
wake_up_process(waiter->process) to wake up the waiter, waiter might run
immediately and reuse the stack. Then, klist_release calls
list_del(&waiter->list) to change previous
wait data and cause prior waiter thread corrupt.

The patch fixes it against kernel 3.9.

Signed-off-by: wang, biao <biao.wang@intel.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/klist.c