]> git.ipfire.org Git - thirdparty/u-boot.git/commit
board: toradex: Quote variables in `test` cmd expression
authorFranz Schnyder <franz.schnyder@toradex.com>
Tue, 31 Mar 2026 08:10:10 +0000 (10:10 +0200)
committerTom Rini <trini@konsulko.com>
Mon, 4 May 2026 17:07:43 +0000 (11:07 -0600)
commit92a04aea6df3e59942614864486bbd0f46d01682
tree44097ed77e5ee243171693ed913a6f9d3df1d943
parentbb0f3eebb3c196d9b6efbbd1e5aa9b16abbb9ad6
board: toradex: Quote variables in `test` cmd expression

With correct POSIX handling, unquoted empty variables can turn the
expression like
test -n ${fdtfile}
into
test -n

The POSIX handling for single argument `test` evaluates it as true,
so the fallback initialization will be skipped unexpectedly.
Quoting variable expansions in `test` expressions will always result in
correct behavior for empty and non-empty values.
This change was triggered by
commit 8b0619579b22 ("cmd: test: fix handling of single-argument form of test")
The aim is to have a less fragile codebase that is not dependent on a
quirk of the shell implementation.

Use quoted variable expansions in `test` expressions throughout.

Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
20 files changed:
board/toradex/aquila-am69/aquila-am69.env
board/toradex/smarc-imx8mp/smarc-imx8mp.env
board/toradex/smarc-imx95/smarc-imx95.env
board/toradex/verdin-am62p/verdin-am62p.env
configs/apalis-imx8_defconfig
configs/apalis_imx6_defconfig
configs/aquila-am69_a72_defconfig
configs/colibri-imx6ull-emmc_defconfig
configs/colibri-imx6ull_defconfig
configs/colibri-imx8x_defconfig
configs/colibri_imx6_defconfig
configs/colibri_imx7_defconfig
configs/colibri_imx7_emmc_defconfig
configs/colibri_vf_defconfig
configs/toradex-smarc-imx8mp_defconfig
configs/toradex-smarc-imx95_defconfig
configs/verdin-am62_a53_defconfig
configs/verdin-am62p_a53_defconfig
configs/verdin-imx8mm_defconfig
configs/verdin-imx8mp_defconfig