]> git.ipfire.org Git - thirdparty/squid.git/commit
Removed SWAPOUT_WRITING assertion from storeSwapMetaBuild().
authorAlex Rousskov <rousskov@measurement-factory.com>
Fri, 11 Mar 2016 17:24:13 +0000 (10:24 -0700)
committerAlex Rousskov <rousskov@measurement-factory.com>
Fri, 11 Mar 2016 17:24:13 +0000 (10:24 -0700)
commit92c08a49dfe5c4b2fe81072c2266eaaf1a79de26
treef7ca3d9bb6a1eeeb06b44c83f6d59b0ebebe7a98
parentb0e14ce2a74e479beac2b4ca05df7fa1ed3b71c3
Removed SWAPOUT_WRITING assertion from storeSwapMetaBuild().

I do not see any strong dependency of that code on that state and we
need to be able to build swap metadata when updating a stale entry
(which would not normally be in the SWAPOUT_WRITING state).

The biggest danger is that somebody calls storeSwapMetaBuild() when the
entry metadata is not yet stable. I am not sure we have a way of
detecting that without using something as overly strong as
SWAPOUT_WRITING.
src/store_swapmeta.cc