]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
TCP: illinois: Incorrect beta usage
authorStephen Hemminger <shemminger@linux-foundation.org>
Tue, 11 Dec 2007 01:39:37 +0000 (09:39 +0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 14 Dec 2007 17:51:07 +0000 (09:51 -0800)
commit931c8cbed400a72c0da0756594154504b4634a2a
treeee73d7946315d4f645e555d1881c625590d19c93
parent978cf44ec452e8fa359b2562a98977d0f76a5b6a
TCP: illinois: Incorrect beta usage

[TCP] illinois: Incorrect beta usage

[ Upstream commit: a357dde9df33f28611e6a3d4f88265e39bcc8880 ]

Lachlan Andrew observed that my TCP-Illinois implementation uses the
beta value incorrectly:
The parameter  beta  in the paper specifies the amount to decrease
*by*:  that is, on loss,
 W <-  W -  beta*W
but in   tcp_illinois_ssthresh() uses  beta  as the amount
to decrease  *to*: W <- beta*W

This bug makes the Linux TCP-Illinois get less-aggressive on uncongested network,
hurting performance. Note: since the base beta value is .5, it has no
impact on a congested network.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/tcp_illinois.c