]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
Fix typo in PROTOCOL_TO_TLS_VERSION in test_ssl (GH-95119)
authorDavid Benjamin <davidben@google.com>
Fri, 22 Jul 2022 00:38:15 +0000 (17:38 -0700)
committerGitHub <noreply@github.com>
Fri, 22 Jul 2022 00:38:15 +0000 (17:38 -0700)
commit934b25dcc492dcbca4da9d63d0d71dc940fc0375
tree3b701ad77c7c4ae53dcb9223672855a84aaa69d8
parentd06c552e35fa80f71d927daa4c8465ee13f37cfc
Fix typo in PROTOCOL_TO_TLS_VERSION in test_ssl (GH-95119)

This appears to be a typo. It causes try_protocol_combo to try to turn
on SSL 3.0 when testing PROTOCOL_SSLv23 (aka PROTOCOL_TLS), which
doesn't make any sense. Fix it to be PROTOCOL_SSLv3.

Without this, try_protocol_combo is actually setting
context.minimum_version to SSLv3 when called as
try_protocol_combo(ssl.PROTOCOL_TLS, ssl.PROTOCOL_TLS, True)

One would think this causes a no-ssl3 OpenSSL build to fail, but OpenSSL
forgot to make SSL_CTX_set_min_proto_version(SSL3_VERSION) does not
notice no-ssl3, so this typo has gone undetected. But we should still
fix the typo because, presumably, a future version of OpenSSL will
remove SSL 3.0 and do so more thoroughly, at which point this will
break.
Lib/test/test_ssl.py