]> git.ipfire.org Git - thirdparty/nftables.git/commit
Revert "cache: recycle existing cache with incremental updates"
authorPablo Neira Ayuso <pablo@netfilter.org>
Wed, 24 Jul 2024 07:38:33 +0000 (09:38 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 24 Jul 2024 07:38:48 +0000 (09:38 +0200)
commit93560d0117639c8685fc287128ab06dec9950fbd
tree0083110b8aa9b41d61144f4474cbf065cb1b9df1
parentbc1f910f502701f1a1d28c7bd723e4be3bac1d8c
Revert "cache: recycle existing cache with incremental updates"

This reverts commit e791dbe109b6dd891a63a4236df5dc29d7a4b863.

Eric Garver reported two issues:

- index with rule breaks, because NFT_CACHE_REFRESH is missing.
- simple set updates.

Moreover, the current process could populate the cache with objects for
listing commands (no generation ID is bumped), while another process
could update the ruleset. Leading to a inconsistent cache due to the
genid + 1 check.

This optimization needs more work and more tests for -i/--interactive,
revert it.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/cache.c