]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Plug memory leaks after migrate_set_error()
authorMarkus Armbruster <armbru@redhat.com>
Sat, 15 Nov 2025 08:34:58 +0000 (09:34 +0100)
committerPeter Xu <peterx@redhat.com>
Fri, 21 Nov 2025 15:33:21 +0000 (10:33 -0500)
commit93817ec39656896543b84b877528ce6fedc3903b
tree19d46aac406087e484a2db5ae4085e720663b257
parent911bdd34ca1a3f9e62836e7bc581e7edc57319be
migration: Plug memory leaks after migrate_set_error()

migrate_set_error(s, err) stores a copy of @err in @s.  The original
@err is not freed.  Most callers free it immediately.  Some callers
free it later, or pass it on.  And some leak it.  Fix those.

Perhaps migrate_set_error(s, err) should take ownership of @err.  The
callers that free it immediately would become simpler, and avoid a
copy and a deallocation.  The others would have to pass
error_copy(err).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/cpr-exec.c
migration/multifd.c