]> git.ipfire.org Git - thirdparty/samba.git/commit
CVE-2018-10919 tests: Add test case for object visibility with limited rights
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 31 Jul 2018 02:14:20 +0000 (14:14 +1200)
committerKarolin Seeger <kseeger@samba.org>
Sat, 11 Aug 2018 19:56:41 +0000 (21:56 +0200)
commit938a55cf348bd95a5a9d940e1894d5a6df3251db
tree6265b87041b1fd3c42c3b8a0195e17b8bd2e39ba
parent49920e7b218770433708cd5889bbf1f9b51d30c0
CVE-2018-10919 tests: Add test case for object visibility with limited rights

Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.

All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).

This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.

This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
selftest/knownfail.d/acl [new file with mode: 0644]
source4/dsdb/tests/python/acl.py