]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFSv4/flexfiles: Fix layout merge mirror check.
authorJonathan Curley <jcurley@purestorage.com>
Mon, 8 Sep 2025 17:35:16 +0000 (17:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Sep 2025 14:29:56 +0000 (16:29 +0200)
commit9391ecf6015435dd262538b01fc96ecaaac63cd5
tree253bf55f37926fe15ed654189be7850f9ea4664e
parentdf1bbf7800d97dc600c9fae54b3010ed19881ca3
NFSv4/flexfiles: Fix layout merge mirror check.

[ Upstream commit dd2fa82473453661d12723c46c9f43d9876a7efd ]

Typo in ff_lseg_match_mirrors makes the diff ineffective. This results
in merge happening all the time. Merge happening all the time is
problematic because it marks lsegs invalid. Marking lsegs invalid
causes all outstanding IO to get restarted with EAGAIN and connections
to get closed.

Closing connections constantly triggers race conditions in the RDMA
implementation...

Fixes: 660d1eb22301c ("pNFS/flexfile: Don't merge layout segments if the mirrors don't match")
Signed-off-by: Jonathan Curley <jcurley@purestorage.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/flexfilelayout/flexfilelayout.c