]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call
authorHans de Goede <hdegoede@redhat.com>
Thu, 26 Aug 2021 14:08:22 +0000 (16:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:48:01 +0000 (11:48 +0200)
commit942a39041bc579902069eed9b8b174deefe41c68
tree4f36af9d3be9b1af65a01c6716a15603024286ae
parent0cd59378234072a71789aeb411a6ae8cce187a34
platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call

[ Upstream commit 0487d4fc42d7f31a56cfd9e2237f9ebd889e6112 ]

As pointed out be Kees Cook if we return -EIO because the
obj->type != ACPI_TYPE_BUFFER, then we must kfree the
output buffer before the return.

Fixes: 1a258e670434 ("platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver")
Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210826140822.71198-1-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/dell-smbios-wmi.c