]> git.ipfire.org Git - thirdparty/linux.git/commit
selftests/bpf: fix veristat comp mode with new stats
authorMahe Tardy <mahe.tardy@gmail.com>
Fri, 20 Dec 2024 15:22:18 +0000 (15:22 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 30 Dec 2024 22:54:20 +0000 (14:54 -0800)
commit9468f39ba478d001f2603ce5bf0e1ab4b97452b8
tree4c8d3f2970a12b86aefaed2e9d8c14bf0a3e2dad
parent4a24035964b706f5937d3128dcd9677b170b766f
selftests/bpf: fix veristat comp mode with new stats

Commit 82c1f13de315 ("selftests/bpf: Add more stats into veristat")
introduced new stats, added by default in the CSV output, that were not
added to parse_stat_value, used in parse_stats_csv which is used in
comparison mode. Thus it broke comparison mode altogether making it fail
with "Unrecognized stat #7" and EINVAL.

One quirk is that PROG_TYPE and ATTACH_TYPE have been transformed to
strings using libbpf_bpf_prog_type_str and libbpf_bpf_attach_type_str
respectively. Since we might not want to compare those string values, we
just skip the parsing in this patch. We might want to translate it back
to the enum value or compare the string value directly.

Fixes: 82c1f13de315 ("selftests/bpf: Add more stats into veristat")
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Tested-by: Mykyta Yatsenko<yatsenko@meta.com>
Link: https://lore.kernel.org/r/20241220152218.28405-1-mahe.tardy@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/veristat.c