]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm: frontswap: invalidate expired data on a dup-store failure
authorWeijie Yang <weijie.yang@samsung.com>
Tue, 2 Dec 2014 23:59:25 +0000 (15:59 -0800)
committerJiri Slaby <jslaby@suse.cz>
Wed, 7 Jan 2015 15:20:07 +0000 (16:20 +0100)
commit94724f27bf02e417629d93101a3fbb0dcfe86c28
treecb68b7b2d6f53d150a609309b3452a0e7d321634
parent6b96727be58559264f7288461022f32444e85303
mm: frontswap: invalidate expired data on a dup-store failure

commit fb993fa1a2f669215fa03a09eed7848f2663e336 upstream.

If a frontswap dup-store failed, it should invalidate the expired page
in the backend, or it could trigger some data corruption issue.
Such as:
 1. use zswap as the frontswap backend with writeback feature
 2. store a swap page(version_1) to entry A, success
 3. dup-store a newer page(version_2) to the same entry A, fail
 4. use __swap_writepage() write version_2 page to swapfile, success
 5. zswap do shrink, writeback version_1 page to swapfile
 6. version_2 page is overwrited by version_1, data corrupt.

This patch fixes this issue by invalidating expired data immediately
when meet a dup-store failure.

Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Seth Jennings <sjennings@variantweb.net>
Cc: Dan Streetman <ddstreet@ieee.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
mm/frontswap.c