]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 23 Apr 2024 16:15:22 +0000 (19:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 May 2024 14:32:39 +0000 (16:32 +0200)
commit94b00cd6b89b9acf636a7437372359f603db6087
tree52b36a483c53d4dea33f24ecfed9e26fbefdf006
parent9dfe29373391455f914d995dc9d901a10ea94247
net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns()

[ Upstream commit 4dcd0e83ea1d1df9b2e0174a6d3e795b3477d64e ]

The rx_chn->irq[] array is unsigned int but it should be signed for the
error handling to work.  Also if k3_udma_glue_rx_get_irq() returns zero
then we should return -ENXIO instead of success.

Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
Link: https://lore.kernel.org/r/05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ti/icssg/icssg_prueth.c