]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: mali-c55: Fix possible ERR_PTR in enable_streams
authorAlper Ak <alperyasinak1@gmail.com>
Sat, 7 Feb 2026 09:18:22 +0000 (12:18 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 19 May 2026 07:01:49 +0000 (09:01 +0200)
commit94c6402e423d36a2bd6f62055a65a0d439d84da7
treeaaefe74fca95ca23bd1b6355729da0273ada2d8c
parentff57ee85854280c6c0662559ed287591b19fc1d5
media: mali-c55: Fix possible ERR_PTR in enable_streams

The media_pad_remote_pad_unique() function returns either a valid
pointer or an ERR_PTR() on failure (-ENOTUNIQ if multiple links are
enabled, -ENOLINK if no connected pad is found). The return value
was assigned directly to isp->remote_src and dereferenced in the
next line without checking for errors, which could lead to an
ERR_PTR dereference.

Add proper error checking with IS_ERR() before dereferencing the
pointer. Also set isp->remote_src to NULL on error to maintain
consistency with other error paths in the function.

Cc: stable@vger.kernel.org
Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/arm/mali-c55/mali-c55-isp.c