]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: videobuf2: Fix device reference leak in vb2_dc_alloc error path
authorHaotian Zhang <vulab@iscas.ac.cn>
Tue, 28 Oct 2025 06:44:43 +0000 (14:44 +0800)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 3 Nov 2025 14:58:42 +0000 (15:58 +0100)
commit94de23a9aa487d7c1372efb161721d7949a177ae
tree8150cbbc4a478182654ea04e85519e4b1c7043e1
parentba92a96b1e95a67cb736d095dceb788207b90a7b
media: videobuf2: Fix device reference leak in vb2_dc_alloc error path

In vb2_dc_alloc(), get_device() is called to increment the device
reference count. However, if subsequent DMA allocation fails
(vb2_dc_alloc_coherent or vb2_dc_alloc_non_coherent returns error),
the function returns without calling put_device(), causing a device
reference leak.

Add put_device() call in the error path before kfree() to properly
release the device reference acquired earlier.

Fixes: de27891f675e ("media: videobuf2: handle non-contiguous DMA allocations")
Cc: stable@vger.kernel.org
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/common/videobuf2/videobuf2-dma-contig.c