]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rust: drm: Drop the use of Opaque for ioctl arguments
authorBeata Michalska <beata.michalska@arm.com>
Thu, 26 Jun 2025 16:23:13 +0000 (18:23 +0200)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 21 Jul 2025 15:53:07 +0000 (17:53 +0200)
commit94febfb5bcfb6ccf02283cc07bf58927c119afca
treee9e6b5cbccdda022de0624198546f3c9a0139f72
parentca2a6abdaee43808034cdb218428d2ed85fd3db8
rust: drm: Drop the use of Opaque for ioctl arguments

With the Opaque<T>, the expectations are that Rust should not
make any assumptions on the layout or invariants of the wrapped
C types. That runs rather counter to ioctl arguments, which must
adhere to certain data-layout constraints. By using Opaque<T>,
ioctl handlers are forced to use unsafe code where none is actually
needed. This adds needless complexity and maintenance overhead,
brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.

Signed-off-by: Beata Michalska <beata.michalska@arm.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250626162313.2755584-1-beata.michalska@arm.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nova/file.rs
drivers/gpu/drm/nova/nova.rs
drivers/gpu/drm/nova/uapi.rs [deleted file]
rust/kernel/drm/ioctl.rs