]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
locking/lockdep: Avoid creating new name string literals in lockdep_set_subclass()
authorAhmed Ehab <bottaawesome633@gmail.com>
Sat, 24 Aug 2024 22:10:30 +0000 (01:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:54:12 +0000 (13:54 +0100)
commit95238df61b65f6999614d66e6c5f0a631eb67909
tree0beabf047b7fc7a13f76909972d1665adc770a16
parentc3d05a6b8d8fb1eb2ca706f9596a5901b11b207c
locking/lockdep: Avoid creating new name string literals in lockdep_set_subclass()

commit d7fe143cb115076fed0126ad8cf5ba6c3e575e43 upstream.

Syzbot reports a problem that a warning will be triggered while
searching a lock class in look_up_lock_class().

The cause of the issue is that a new name is created and used by
lockdep_set_subclass() instead of using the existing one. This results
in a lock instance has a different name pointer than previous registered
one stored in lock class, and WARN_ONCE() is triggered because of that
in look_up_lock_class().

To fix this, change lockdep_set_subclass() to use the existing name
instead of a new one. Hence, no new name will be created by
lockdep_set_subclass(). Hence, the warning is avoided.

[boqun: Reword the commit log to state the correct issue]

Reported-by: <syzbot+7f4a6f7f7051474e40ad@syzkaller.appspotmail.com>
Fixes: de8f5e4f2dc1f ("lockdep: Introduce wait-type checks")
Cc: stable@vger.kernel.org
Signed-off-by: Ahmed Ehab <bottaawesome633@gmail.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/lkml/20240824221031.7751-1-bottaawesome633@gmail.com/
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/lockdep.h