]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Input: adp5589-keys - fix adp5589_gpio_get_value()
authorNuno Sa <nuno.sa@analog.com>
Tue, 1 Oct 2024 14:47:23 +0000 (07:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:41 +0000 (15:11 +0200)
commit95555f9f844db1c112c2e3848f04f957433a97af
tree5c724316da77d34812455ba0218eb726c53b7c0d
parent4449fedb8a710043fc0925409eba844c192d4337
Input: adp5589-keys - fix adp5589_gpio_get_value()

commit c684771630e64bc39bddffeb65dd8a6612a6b249 upstream.

The adp5589 seems to have the same behavior as similar devices as
explained in commit 910a9f5636f5 ("Input: adp5588-keys - get value from
data out when dir is out").

Basically, when the gpio is set as output we need to get the value from
ADP5589_GPO_DATA_OUT_A register instead of ADP5589_GPI_STATUS_A.

Fixes: 9d2e173644bb ("Input: ADP5589 - new driver for I2C Keypad Decoder and I/O Expander")
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20241001-b4-dev-adp5589-fw-conversion-v1-2-fca0149dfc47@analog.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/keyboard/adp5589-keys.c