]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vme: Fix wrong pointer utilization in ca91cx42_slave_get
authorAugusto Mecking Caringi <augustocaringi@gmail.com>
Tue, 10 Jan 2017 10:45:00 +0000 (10:45 +0000)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:40:42 +0000 (17:40 +0100)
commit955f82ec9a0a251ed1ebe16ce0efd564337ce439
tree6776f7cf3e1fed4fd43800e0d75d4bf77192142c
parentbe9ab8202e194fbc6b066b7e2dbabccd9d74a362
vme: Fix wrong pointer utilization in ca91cx42_slave_get

commit c8a6a09c1c617402cc9254b2bc8da359a0347d75 upstream.

In ca91cx42_slave_get function, the value pointed by vme_base pointer is
set through:

*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);

So it must be dereferenced to be used in calculation of pci_base:

*pci_base = (dma_addr_t)*vme_base + pci_offset;

This bug was caught thanks to the following gcc warning:

drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
*pci_base = (dma_addr_t)vme_base + pci_offset;

Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Acked-By: Martyn Welch <martyn@welchs.me.uk>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/vme/bridges/vme_ca91cx42.c