]> git.ipfire.org Git - thirdparty/libvirt.git/commit
lib: Prefer WITH_* prefix for #if conditionals
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 1 Sep 2020 11:27:44 +0000 (13:27 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 2 Sep 2020 08:28:10 +0000 (10:28 +0200)
commit95b9db4ee27d6c58f868eb720a944c7f77da6e68
treec6f45d1072f1b6dad63c3ef7e46c731e943b2732
parent59d896ced13ae4f42587ee9204936d6f35682f2f
lib: Prefer WITH_* prefix for #if conditionals

Currently, we are mixing: #if HAVE_BLAH with #if WITH_BLAH.
Things got way better with Pavel's work on meson, but apparently,
mixing these two lead to confusing and easy to miss bugs (see
31fb929eca for instance). While we were forced to use HAVE_
prefix with autotools, we are free to chose our own prefix with
meson and since WITH_ prefix appears to be more popular let's use
it everywhere.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
71 files changed:
build-aux/syntax-check.mk
docs/coding-style.rst
meson.build
src/admin/libvirt-admin.c
src/conf/nwfilter_conf.c
src/cpu/cpu_arm.c
src/internal.h
src/libvirt.c
src/libxl/libxl_capabilities.c
src/libxl/libxl_conf.c
src/libxl/xen_xl.c
src/locking/lock_driver_sanlock.c
src/locking/lock_manager.c
src/network/bridge_driver.c
src/nwfilter/nwfilter_dhcpsnoop.c
src/nwfilter/nwfilter_learnipaddr.c
src/qemu/qemu_namespace.c
src/qemu/qemu_process.c
src/rpc/virnetsocket.c
src/storage/storage_backend_rbd.c
src/storage/storage_driver.c
src/storage/storage_util.c
src/util/iohelper.c
src/util/virbpf.c
src/util/virbpf.h
src/util/vircgroupv2devices.c
src/util/virdbus.c
src/util/virdbuspriv.h
src/util/virfile.c
src/util/virgettext.c
src/util/virhostcpu.c
src/util/virhostmem.c
src/util/virhostuptime.c
src/util/virlog.c
src/util/virmodule.c
src/util/virnetdev.c
src/util/virnetdev.h
src/util/virnetdevbridge.c
src/util/virnetdevip.c
src/util/virnetdevmacvlan.c
src/util/virnetdevtap.c
src/util/virnetlink.c
src/util/virnetlink.h
src/util/virnuma.c
src/util/virperf.c
src/util/virprocess.c
src/util/virstring.c
src/util/virthread.c
src/util/virutil.c
src/util/virutil.h
src/util/virvsock.c
tests/eventtest.c
tests/libxlxml2domconfigtest.c
tests/meson.build
tests/securityselinuxhelper.c
tests/virfilemock.c
tests/virfiletest.c
tests/virmock.h
tests/virmockstathelpers.c
tests/virnetsockettest.c
tests/virnettlscontexttest.c
tests/virnettlshelpers.c
tests/virnettlshelpers.h
tests/virnettlssessiontest.c
tests/virportallocatormock.c
tests/virportallocatortest.c
tests/virstoragetest.c
tests/vshtabletest.c
tools/nss/libvirt_nss.c
tools/nss/libvirt_nss.h
tools/virt-host-validate.c