]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PCI/pwrctrl: Do not try to power on/off devices that don't need pwrctrl
authorManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Tue, 21 Apr 2026 10:41:01 +0000 (16:11 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 27 Apr 2026 14:47:15 +0000 (09:47 -0500)
commit95c4920701dfca6a8cf4986112898382fa7afc0f
treed6655f818e5442d3fe6230d8c207e1bc023973a5
parent73ae5392b0cfcce02efa23ee7123d8764ef070a8
PCI/pwrctrl: Do not try to power on/off devices that don't need pwrctrl

pci_pwrctrl_is_required() detects whether a device needs PCI pwrctrl
support. It is currently used in pci_pwrctrl_create_device(), but not in
pci_pwrctrl_power_{on/off}_device() APIs. This leads to pwrctrl core trying
to power on/off incompatible devices like USB hub downstream ports defined
in DT.

Add this check to prevent pwrctrl core from poking at wrong devices.

Fixes: b35cf3b6aa1e ("PCI/pwrctrl: Add APIs to power on/off pwrctrl devices")
Reported-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
[bhelgaas: split pci_pwrctrl_is_required() move to separate patch]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260421104102.12322-1-manivannan.sadhasivam@oss.qualcomm.com
drivers/pci/pwrctrl/core.c