]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: mchp-pci1xxx: Fix a possible null pointer dereference in pci1xxx_spi_probe
authorHuai-Yuan Liu <qq810974084@gmail.com>
Wed, 3 Apr 2024 01:42:21 +0000 (09:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:38:13 +0000 (16:38 +0200)
commit95e5d9eb26705a9a76d2ef8bcba9ee2e195d653d
treecbeba69026ad9649a873c5b2799eb621da03c88d
parent4525a918f99a12089a8fc677f21b9ed66c4aed96
spi: mchp-pci1xxx: Fix a possible null pointer dereference in pci1xxx_spi_probe

[ Upstream commit 1f886a7bfb3faf4c1021e73f045538008ce7634e ]

In function pci1xxxx_spi_probe, there is a potential null pointer that
may be caused by a failed memory allocation by the function devm_kzalloc.
Hence, a null pointer check needs to be added to prevent null pointer
dereferencing later in the code.

To fix this issue, spi_bus->spi_int[iter] should be checked. The memory
allocated by devm_kzalloc will be automatically released, so just directly
return -ENOMEM without worrying about memory leaks.

Fixes: 1cc0cbea7167 ("spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX PCIe switch")
Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
Link: https://msgid.link/r/20240403014221.969801-1-qq810974084@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-pci1xxxx.c