]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: emu10k1: Fix card shortname string buffer overflow
authorTakashi Iwai <tiwai@suse.de>
Mon, 27 Apr 2015 11:00:09 +0000 (13:00 +0200)
committerZefan Li <lizefan@huawei.com>
Fri, 18 Sep 2015 01:20:32 +0000 (09:20 +0800)
commit96a987dfe32ffe562be8876392d0539437b0d780
tree2e046e4958b742a55c01f657d41eb052ef50b31d
parente35facb7a9bb47ba4335b14cb73f079b7cf5b25d
ALSA: emu10k1: Fix card shortname string buffer overflow

commit d02260824e2cad626fb2a9d62e27006d34b6dedc upstream.

Some models provide too long string for the shortname that has 32bytes
including the terminator, and it results in a non-terminated string
exposed to the user-space.  This isn't too critical, though, as the
string is stopped at the succeeding longname string.

This patch fixes such entries by dropping "SB" prefix (it's enough to
fit within 32 bytes, so far).  Meanwhile, it also changes strcpy()
with strlcpy() to make sure that this kind of problem won't happen in
future, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Zefan Li <lizefan@huawei.com>
sound/pci/emu10k1/emu10k1.c
sound/pci/emu10k1/emu10k1_main.c