]> git.ipfire.org Git - thirdparty/libvirt.git/commit
esx: Fix 'vpx' MAC address range and allow arbitrary MAC addresses
authorMatthias Bolte <matthias.bolte@googlemail.com>
Sat, 2 Jan 2010 22:58:24 +0000 (23:58 +0100)
committerMatthias Bolte <matthias.bolte@googlemail.com>
Thu, 7 Jan 2010 00:38:19 +0000 (01:38 +0100)
commit96ceb124439ed8ba0fe549d71c64eff8c2c8cddc
treebfaf302acf9334c545e5ed02ee45c16cf06d35f2
parent79f94196523807f35eb75aec85d2a9de7ca238c3
esx: Fix 'vpx' MAC address range and allow arbitrary MAC addresses

The MAC addresses with 00:50:56 prefix are split into several ranges:

  00:50:56:00:00:00 - 00:50:56:3f:ff:ff  'static' range (manually assigned)
  00:50:56:80:00:00 - 00:50:56:bf:ff:ff  'vpx' range (assigned by a VI Client)

Erroneously the 'vpx' range was assumed to be larger and to occupy the
remaining addresses of the 00:50:56 prefix that are not part of the 'static'
range.

00:50:56 was used as prefix for generated MAC addresses, this is not possible
anymore, because there are gaps in the allowed ranges. Therefore, change the
prefix to 00:0c:29 which is the prefix for auto generated MAC addresses anyway.

Allow arbitrary MAC addresses to be used and set the checkMACAddress VMX option
to false in case the MAC address doesn't fall into any predefined range.

* docs/drvesx.html.in: update website accordingly
* src/esx/esx_driver.c: set the auto generation prefix to 00:0c:29
* src/esx/esx_vmx.c: fix MAC address range handling and allow arbitrary MAC
  addresses
* tests/vmx2xml*, tests/xml2vmx*: add some basic MAC address range tests
21 files changed:
docs/drvesx.html.in
src/esx/esx_driver.c
src/esx/esx_vmx.c
tests/vmx2xmldata/vmx2xml-ethernet-generated.vmx [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-generated.xml [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-other.vmx [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-other.xml [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-static.vmx [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-static.xml [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-vpx.vmx [new file with mode: 0644]
tests/vmx2xmldata/vmx2xml-ethernet-vpx.xml [new file with mode: 0644]
tests/vmx2xmltest.c
tests/xml2vmxdata/xml2vmx-ethernet-generated.vmx [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-generated.xml [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-other.vmx [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-other.xml [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-static.vmx [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-static.xml [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-vpx.vmx [new file with mode: 0644]
tests/xml2vmxdata/xml2vmx-ethernet-vpx.xml [new file with mode: 0644]
tests/xml2vmxtest.c