]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: Clarify get_outer_instance() handling in propagate_to_outer_instance()
authorShardul Bankar <shardulsb08@gmail.com>
Tue, 21 Oct 2025 08:08:46 +0000 (13:38 +0530)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 21 Oct 2025 16:39:05 +0000 (09:39 -0700)
commit96d31dff3fa428845aad05c5ae3a1593f6e17add
tree97403c7a4c80ef34f26a2d8af5128092f0c19e91
parent04a899573fb87273a656f178b5f920c505f68875
bpf: Clarify get_outer_instance() handling in propagate_to_outer_instance()

propagate_to_outer_instance() calls get_outer_instance() and uses the
returned pointer to reset and commit stack write marks. Under normal
conditions, update_instance() guarantees that an outer instance exists,
so get_outer_instance() cannot return an ERR_PTR.

However, explicitly checking for IS_ERR(outer_instance) makes this code
more robust and self-documenting. It reduces cognitive load when reading
the control flow and silences potential false-positive reports from
static analysis or automated tooling.

No functional change intended.

Signed-off-by: Shardul Bankar <shardulsb08@gmail.com>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20251021080849.860072-1-shardulsb08@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/liveness.c