]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix catcache invalidation of a list entry that's being built
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 14 Jan 2025 12:28:49 +0000 (14:28 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 14 Jan 2025 12:35:11 +0000 (14:35 +0200)
commit96e61b2792a5a4820504aa5e1defaa8582858cd0
treeffd7deea35fc6642e948dfbeaec06edd0672ecb1
parente027ee9902fa414d766c8dc2589c6a3d7aeaa53a
Fix catcache invalidation of a list entry that's being built

If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.

To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.

Back-patch to all supported versions.

Reviewed-by: Noah Misch
Discussion: https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc880@iki.fi
src/backend/utils/cache/catcache.c
src/backend/utils/cache/inval.c
src/include/utils/catcache.h
src/test/modules/test_misc/meson.build
src/test/modules/test_misc/t/007_catcache_inval.pl [new file with mode: 0644]
src/tools/pgindent/typedefs.list